crates/keyshare/src/threshold_keyshare.rs (1)

266-299: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Start the DKG timeout clock on CiphernodeSelected, not in ThresholdKeyshareState::new.

resolve_timeout(...) subtracts elapsed time from dkg_started_at_unix_secs, but Line 298 seeds that value when the actor/state is constructed. If the actor exists for any meaningful time before DKG actually begins, the collectors inherit a reduced or even exhausted budget and can timeout immediately on startup. Initialize this field to None here and stamp it when handle_ciphernode_selected begins the DKG flow, before the collectors are created.

💡 Suggested direction

 pub struct ThresholdKeyshareState {
     ...
     #[serde(default)]
     pub dkg_started_at_unix_secs: Option<u64>,
     ...
 }

 impl ThresholdKeyshareState {
     pub fn new(
         e3_id: E3id,
         party_id: PartyId,
         state: KeyshareState,
         threshold_m: u64,
         threshold_n: u64,
         params: ArcBytes,
         address: String,
         proof_aggregation_enabled: bool,
     ) -> Self {
         Self {
             e3_id,
             address,
             party_id,
             state,
             threshold_m,
             threshold_n,
             params,
             aggregated_pk: None,
             expelled_parties: HashSet::new(),
             honest_parties: None,
-            dkg_started_at_unix_secs: Some(now_unix_secs()),
+            dkg_started_at_unix_secs: None,
             proof_aggregation_enabled,
         }
     }
 }

Then, in handle_ciphernode_selected, set dkg_started_at_unix_secs = Some(now_unix_secs()) before calling ensure_collector(...) / ensure_encryption_key_collector(...).

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/keyshare/src/threshold_keyshare.rs` around lines 266 - 299, The
dkg_started_at_unix_secs is being initialized in ThresholdKeyshareState::new
which causes resolve_timeout to undercount if the actor lives before DKG starts;
change the initialization in ThresholdKeyshareState::new to set
dkg_started_at_unix_secs to None, and then in handle_ciphernode_selected set
self.dkg_started_at_unix_secs = Some(now_unix_secs()) immediately before calling
ensure_collector(...) and ensure_encryption_key_collector(...), leaving
resolve_timeout to compute elapsed correctly.